Populate github owner/repo keys with default values from git remote #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
This is great @alejandrohdezma!
For a wider reach, maybe we could update the docs mentioning this new behaviour?
|
@calvellido 🤦 I intended to do it, but I totally forgot. I'll add during the day :) thanks! |
juanpedromoreno
approved these changes
Mar 3, 2020
|
@calvellido Done! f6cd7e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Most of the projects using this plugin use either Travis, Github Actions or other similar CIs. All these have in common that they set a git remote
originpointing to the original repository. We can extract that information from git to pre-populate themicrositeGithubOwnerandmicrositeGithubRepo.What has been done in this PR?
Populate by default the
micrositeGithubOwnerandmicrositeGithubRepowith the information extracted from callinggit ls-remote --get-url origin.